(update): refactored code to make it more readable #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arctos2win
reviewed
Nov 2, 2024
| local xPlayer = ESX.GetPlayerFromId(source) | ||
| local timeNow = os.clock() | ||
|
|
||
| if not xPlayer.job.name == 'taxi' then |
| end | ||
| end) | ||
|
|
||
| ESX.RegisterServerCallback("esx_taxijob:SpawnVehicle", function(source, cb, model , props) | ||
| local xPlayer = ESX.GetPlayerFromId(source) | ||
|
|
||
| if xPlayer.job.name ~= "taxi" then | ||
| if not xPlayer.job.name == "taxi" then |
| local xPlayer = ESX.GetPlayerFromId(source) | ||
|
|
||
| if not xPlayer.job.name == 'taxi' then |
| -- is there enough in the society? | ||
| if count > 0 and item.count >= count then | ||
| -- can the player carry the said amount of x item? | ||
| if xPlayer.canCarryItem(itemName, count) then |
There was a problem hiding this comment.
should be
if not xPlayer.canCarryItem(itemName, count) then
return xPlayer.showNotification(TranslateCap('player_cannot_hold'))
end
-- rest of the code here
| local item = inventory.getItem(itemName) | ||
|
|
||
| -- is there enough in the society? | ||
| if count > 0 and item.count >= count then |
There was a problem hiding this comment.
same thing here should get rid of nestling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored code + removed math.randomseed since it wasn't getting used anywhere